Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add react keyboard #1963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ValentynaD
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the React component! 🎉 The code meets all the task requirements and constraints. While the handleKeyUp method should be correctly bound using the arrow function syntax, it's always a good practice to double-check this binding to avoid any potential issues. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

}

componentDidMount() {
document.addEventListener('keyup', this.handleKeyUp);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the handleKeyUp method is correctly bound to the component instance. Although the arrow function syntax should bind this correctly, it's a good practice to verify that the method is properly bound, especially if you encounter issues with this being undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants