some commit message #1966
some commit message #1966
Conversation
There was a problem hiding this comment.
Great job on implementing the React component! 🎉 Your code meets all the task requirements and constraints, and you've handled event listeners effectively. The only minor point to consider is the conditional setState in your keyUpHandler. If you want the state to update even when the same key is pressed consecutively, you might want to adjust this logic. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/App.tsx
Outdated
| this.setState(prevState => | ||
| prevState.pressedKey !== event.key ? { pressedKey: event.key } : null |
There was a problem hiding this comment.
The setState method is conditionally updating the state only if the pressed key is different from the previous one. If the same key is pressed consecutively, the state will not update, and the console will still log the key. If this is not the intended behavior, consider removing the condition to always update the state with the pressed key.
DEMO LINK