Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ #1975

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

+ #1975

wants to merge 1 commit into from

Conversation

Tomarikaa
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the App component! 🎉 The functionality is spot on, and you've met all the task requirements. Just a small note: consider adjusting the event type in the handlePressedKeyChange method for better accuracy. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

pressedKey: '',
};

handlePressedKeyChange = (event: KeyboardEvent) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handlePressedKeyChange method is using KeyboardEvent as the type for the event parameter. However, when adding an event listener to the document, the correct type should be React.KeyboardEvent or Event since it's a native event. Consider changing the type to Event and then casting it to KeyboardEvent inside the function if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants