Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #1976

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add solution #1976

wants to merge 2 commits into from

Conversation

ZorosMG
Copy link

@ZorosMG ZorosMG commented Feb 25, 2025

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the App component! 🎉 Your code meets all the task requirements and constraints. The use of event listeners and state management is well done. Just a small note: you've correctly used the arrow function syntax for handleKeyUp, which ensures proper binding. Keep up the great work and continue honing your skills! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/App.tsx Outdated
}

componentDidMount() {
document.addEventListener('keyup', this.handleKeyUp);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handleKeyUp method is used as an event handler, and it's important to ensure it is correctly bound to the component instance. In this case, the arrow function syntax is used, which automatically binds the method to the instance, so there is no issue here. However, if you were not using an arrow function, you would need to bind the method in the constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants