Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1978

wants to merge 1 commit into from

Conversation

lucasschumann
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the App component! 🎉 The code meets all the task requirements and constraints, and you've handled the keyboard events and state updates correctly. There's a minor suggestion to improve compatibility: consider changing the handleKey method parameter type to React.KeyboardEvent to align with React's synthetic event system. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

key: '',
};

handleKey = (event: KeyboardEvent) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handleKey method should use React.KeyboardEvent instead of KeyboardEvent to ensure compatibility with React's synthetic event system. Change the parameter type to event: React.KeyboardEvent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants