add task solution #1981
add task solution #1981
Conversation
There was a problem hiding this comment.
Great job on implementing the App component! 🎉 The functionality is spot on, and you've met all the core requirements of the task. There are a couple of minor improvements you could make: consider importing KeyboardEvent from 'react' to align with React's synthetic events, and type the props parameter in the constructor as props: {} or props: Record<string, never>. These tweaks will enhance your code's clarity and maintainability. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| export class App extends React.Component { | ||
| state = { keypressed: '' }; | ||
|
|
||
| constructor(props: {}) { |
There was a problem hiding this comment.
The props parameter in the constructor should be typed properly. Since it's an empty object, you can use props: {} or props: Record<string, never> to indicate that no props are expected.
| this.handleKeyup = this.handleKeyup.bind(this); | ||
| } | ||
|
|
||
| handleKeyup(event: KeyboardEvent) { |
There was a problem hiding this comment.
The KeyboardEvent type should be imported from 'react' instead of using the default DOM event type. Change KeyboardEvent to React.KeyboardEvent to ensure compatibility with React's synthetic events.
DEMO LINK