init commit #1854
init commit #1854
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 The code meets the core functionality and constraints, with only minor issues related to prop naming consistency. These don't impact the overall functionality, so feel free to merge. Keep up the good work and consider aligning prop names for clarity in future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/App.tsx
Outdated
| </h1> | ||
| <Tabs | ||
| tabs={tabs} | ||
| isSelected={selectedTabId} |
There was a problem hiding this comment.
The prop isSelected should be renamed to selectedTabId to match the task description and the Tabs component's expected prop name. This ensures consistency and clarity in the code.
src/components/Tabs/Tabs.tsx
Outdated
| title: string; | ||
| content: string; | ||
| }[]; | ||
| isSelected: string; |
There was a problem hiding this comment.
The prop isSelected should be renamed to selectedTabId to maintain consistency with the task description and the App.tsx file. This will ensure that the prop names are consistent across the application.
src/components/Tabs/Tabs.tsx
Outdated
| onTabSelected: (tabID: string) => void; | ||
| }; | ||
|
|
||
| export const Tabs = ({ tabs, isSelected, onTabSelected }: Props) => { |
There was a problem hiding this comment.
Update the destructured prop isSelected to selectedTabId to match the corrected prop name in the Props type.
src/components/Tabs/Tabs.tsx
Outdated
| return ( | ||
| <li | ||
| key={tab.id} | ||
| className={isSelected === tab.id ? 'is-active' : ''} |
There was a problem hiding this comment.
Ensure that the className logic uses the updated prop name selectedTabId instead of isSelected.
src/components/Tabs/Tabs.tsx
Outdated
| </div> | ||
|
|
||
| <div className="block" data-cy="TabContent"> | ||
| {tabs.map(tab => (tab.id === isSelected ? tab.content : ''))} |
There was a problem hiding this comment.
Update the condition to use selectedTabId instead of isSelected to match the corrected prop name.
DEMO LINK