add task solution #1718
Open
add task solution #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadiimvooo
suggested changes
Feb 9, 2025
src/components/footer.tsx
Outdated
Comment on lines
26
to
51
| <a | ||
| href="#/" | ||
| className={`filter__link ${newFilter === 'All' ? 'selected' : ''} `} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setNewFilter('All')} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={`filter__link ${newFilter === 'Active' ? 'selected' : ''} `} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setNewFilter('Active')} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={`filter__link ${newFilter === 'Completed' ? 'selected' : ''} `} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setNewFilter('Completed')} | ||
| > | ||
| Completed | ||
| </a> |
volodymyr-soltys97
suggested changes
Feb 10, 2025
| return ( | ||
| <div | ||
| data-cy="ErrorNotification" | ||
| className={`notification is-danger is-light has-text-weight-normal ${errorMessage.length === 0 ? 'hidden' : ''}`} |
There was a problem hiding this comment.
Use the classnames library for add classes with condition, fix it everywhere
src/components/footer.tsx
Outdated
Comment on lines
22
to
50
| <a | ||
| href="#/" | ||
| className={classNames('filter__link', { | ||
| selected: newFilter === Filter.All, | ||
| })} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setNewFilter(Filter.All)} | ||
| > | ||
| All | ||
| </a> | ||
| <a | ||
| href="#/active" | ||
| className={classNames('filter__link', { | ||
| selected: newFilter === Filter.Active, | ||
| })} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setNewFilter(Filter.Active)} | ||
| > | ||
| Active | ||
| </a> | ||
| <a | ||
| href="#/completed" | ||
| className={classNames('filter__link', { | ||
| selected: newFilter === Filter.Completed, | ||
| })} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setNewFilter(Filter.Completed)} | ||
| > | ||
| Completed |
There was a problem hiding this comment.
Use Object.values(Filter) and render these options with map() method
etojeDenys
approved these changes
Feb 12, 2025
Comment on lines
+43
to
+45
| useEffect(() => { | ||
| setTodoClear(todos.some(todo => todo.completed)); // Тепер відображається, коли є завершені todo | ||
| }, [todos]); |
There was a problem hiding this comment.
it can be just a var
const hasCompletedTodo = todos.some(todo => todo.completed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK