Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #1729

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #1729

wants to merge 2 commits into from

Conversation

Dominik-Dudek-code
Copy link

@Dominik-Dudek-code Dominik-Dudek-code commented Feb 17, 2025 •
edited
Loading

@Dominik-Dudek-code
Copy link
Author

Basically, there are a lot of components and files here, as well as many methods that are not yet working because I copied the entire file from another task. Therefore, please review only those parts that relate to this task, which generally include part of
TodoContext, whole NotificationContext, Loader, Notification, and the mostly completed but untested TodoInput.

@Dominik-Dudek-code
Copy link
Author

I would just like to add that the methods for renaming and deleting only work on the locally stored state, because as I mentioned, they are from another task. I will implement them properly in the next part of the current task.

danon321
danon321 suggested changes Feb 17, 2025
View reviewed changes
Copy link

@danon321 danon321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link do demo nie działa :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danon321 danon321 danon321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dominik-Dudek-code @danon321