Develop #1731
Open
Develop #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naziamoff
approved these changes
Feb 26, 2025
Comment on lines
+88
to
+93
| handleFilterSelect( | ||
| todos, | ||
| FilterOptions.Completed, | ||
| onFilterSelect, | ||
| setIsSelected, | ||
| ) |
There was a problem hiding this comment.
this piece of code is often repeated, however only one prop differs.
Also, 2 of the props are taken from the parent component as a prop, it means that it can be simplified. Do we need to expect todos and onFilterSelect in the function?
| <button | ||
| type="button" | ||
| className={classNames('todoapp__toggle-all', { | ||
| active: verifyActiveTodos(todos), |
There was a problem hiding this comment.
I would say we don't need a function for that since it is only used once
| todos: Todo[]; | ||
| }; | ||
|
|
||
| export const Header: FC<Props> = ({ todos }) => { |
There was a problem hiding this comment.
we can return right away since there's no component logic inside
Comment on lines
+9
to
+11
| export const TodoList: FC<Props> = ({ todos }) => { | ||
| return ( | ||
| <section className="todoapp__main" data-cy="TodoList"> |
There was a problem hiding this comment.
return statement is not necessary here, we can return right away by wrapping component result in the round braces instead of the curly ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK