solution #1735
Open
solution #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Feb 20, 2025
etojeDenys
suggested changes
Feb 22, 2025
src/Components/Footer.tsx
Outdated
Comment on lines
5
to
6
| filter: 'all' | 'active' | 'completed'; | ||
| handleFilterChenge: (newFilter: 'all' | 'active' | 'completed') => void; |
There was a problem hiding this comment.
create some custom type or enum and reuse it everywhere
volodymyr-soltys97
suggested changes
Feb 24, 2025
src/App.tsx
Outdated
| const [title, setTitle] = useState<string>(''); | ||
| const [loading, setLoading] = useState<boolean>(false); | ||
| const [error, setError] = useState<string | null>(null); | ||
| const [filter, setFilter] = useState<FilterType>('all'); |
There was a problem hiding this comment.
Create a enum for 'all', 'active', 'completed' and use it everywhere
src/Components/ErrorNotification.tsx
Outdated
| onClose, | ||
| }) => ( | ||
| <div | ||
| className={`notification is-danger is-light has-text-weight-normal ${isVisible ? '' : 'hidden'}`} |
There was a problem hiding this comment.
Use the classnames library for add classes with condition, fix it everywhere
src/Components/Footer.tsx
Outdated
Comment on lines
24
to
46
| <a | ||
| href="#/" | ||
| className={`filter__link ${filter === 'all' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => handleFilterChange('all')} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={`filter__link ${filter === 'active' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => handleFilterChange('active')} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={`filter__link ${filter === 'completed' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => handleFilterChange('completed')} |
There was a problem hiding this comment.
Use Object.values(your created enum) and render these options with map() method
src/Components/Header.tsx
Outdated
| только если все задачи выполнены. */} | ||
| <button | ||
| type="button" | ||
| className={`todoapp__toggle-all ${todos.length > 0 && todos.every(todo => todo.completed) ? 'active' : ''}`} |
There was a problem hiding this comment.
Move this logic from jsx to the helper variable
src/Components/TodoItems.tsx
Outdated
| /> | ||
| </label> | ||
| <span data-cy="TodoTitle" className="todo__title"> | ||
| {todo.title} |
src/Components/TodoItems.tsx
Outdated
| @@ -0,0 +1,50 @@ | |||
| /* eslint-disable jsx-a11y/label-has-associated-control */ | |||
There was a problem hiding this comment.
Remove file to TodoItem.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK