ADD Check to ensure that the primaryKey does not contain a double-quote

mathiask88 · Apr 10, 2023 · 512577f · 512577f
1 parent 34da670
commit 512577f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 # RxDB Changelog
 
 <!-- CHANGELOG NEWEST -->
-
+- ADD Check to ensure that the primaryKey does not contain a double-quote.
 <!-- ADD new changes here! -->
 
 <!-- /CHANGELOG NEWEST -->

diff --git a/src/plugins/dev-mode/check-document.ts b/src/plugins/dev-mode/check-document.ts
@@ -35,5 +35,13 @@ export function ensurePrimaryKeyValid(
             document: docData
         });
     }
+    if (
+        primaryKey.includes('"')
+    ) {
+        throw newRxError('DOC23', {
+            primaryKey,
+            document: docData
+        });
+    }
 }
 
diff --git a/src/plugins/dev-mode/error-messages.ts b/src/plugins/dev-mode/error-messages.ts
@@ -115,6 +115,7 @@ export const ERROR_MESSAGES = {
     DOC20: 'PrimaryKey missing',
     DOC21: 'PrimaryKey must be equal to PrimaryKey.trim(). It cannot start or end with a whitespace',
     DOC22: 'PrimaryKey must not contain a linebreak',
+    DOC23: 'PrimaryKey must not contain a double-quote ["]',
 
     // data-migrator.js
     DM1: 'migrate() Migration has already run',