Extract Common Modal Components To Reduce Duplication #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianAndersen
added
the
Refactor
AdrianAndersen
force-pushed
the
extract-modal-components
branch
from
e8225d5 to
3a98d91
Compare
mathiazom
reviewed
Jan 25, 2025
AdrianAndersen
force-pushed
the
extract-modal-components
branch
from
3a98d91 to
1063529
Compare
mathiazom
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts common markup for the modals to reduce duplication. These bits of code have been copy-pasted over and over, and we really should have extracted them earlier 🤠
These new components keep the design very similar to before, with slight changes due to the standardization of components where our original code differs slightly.