Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow calling Treemap API directly #59

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 10, 2025

Description:

The Treemap API is meant to be called by the visualization only. Therefor there is no need to allow calling the API from within another API method.

Furthermore I've added a check that the called API actually returns a DataTable, if that isn't the case it would otherwise throw errors when trying to use the returned value as a DataTable.

Review

@sgiehl sgiehl requested a review from a team January 10, 2025 13:59
Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I can confirm with this change it returns an empty response instead of error.

@AltamashShaikh AltamashShaikh merged commit 271daae into 5.x-dev Jan 10, 2025
6 checks passed
@AltamashShaikh AltamashShaikh deleted the improvecheck branch January 10, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants