send queue: add useful logs when aborting/editing a local echo #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3630 +/- ##
==========================================
+ Coverage 84.19% 84.22% +0.02%
==========================================
Files 256 256
Lines 26555 26560 +5
==========================================
+ Hits 22359 22370 +11
+ Misses 4196 4190 -6 ☔ View full report in Codecov by Sentry. |
poljar
requested changes
Jul 1, 2024
poljar
approved these changes
Jul 1, 2024
| @@ -879,21 +886,28 @@ impl SendHandle { | |||
| /// | |||
| /// Returns true if the event to be sent was replaced, false if not (i.e. | |||
| /// the event had already been sent). | |||
| #[instrument(skip(self, new_content), fields(room_id = %self.room.inner.room.room_id(), txn_id = %self.transaction_id))] | |||
There was a problem hiding this comment.
That's a bit of a long line, sadly rustfmt doesn't want to touch macros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These logs may help with debugging issues around editing of local echoes.
Part of #3361.