sdk: don't clobber the DM list if we failed to deserialize the previous m.direct event
#3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3634 +/- ##
==========================================
+ Coverage 84.19% 84.22% +0.03%
==========================================
Files 256 256
Lines 26594 26597 +3
==========================================
+ Hits 22391 22402 +11
+ Misses 4203 4195 -8 ☔ View full report in Codecov by Sentry. |
bnjbvr
force-pushed
the
bnjbvr/dont-clobber-dm-list
branch
from
3df04a8
to
7bb64ea
Compare
…us m.direct event Report a deserialization failure and do not mark the room as a DM, instead of incorrectly restarting from an empty DM list. Fixes #3410.
bnjbvr
force-pushed
the
bnjbvr/dont-clobber-dm-list
branch
from
7bb64ea
to
5662b59
Compare
Hywan
approved these changes
Jul 3, 2024
| Mock::given(method("GET")) | ||
| .and(path("_matrix/client/r0/user/@example:localhost/account_data/m.direct")) | ||
| .and(header("authorization", "Bearer 1234")) | ||
| .respond_with(ResponseTemplate::new(200).set_body_json(json!(["hey", null, true, 42]))) |
There was a problem hiding this comment.
That's my new catchy phrase: hey null true 42!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3410.
I don't think there's a point in waiting for the
m.directdata to come through sync, as 1. it would require a causality link (channel) between getting the m.direct event and this method — not impossible but tedious, and 2. marking a room as DM doesn't occur that often, so there's no need to optimize for it that much.