timeline: adjust day divider and read marker items after a local echo has been redacted/edited #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3665 +/- ##
==========================================
- Coverage 84.32% 84.29% -0.03%
==========================================
Files 258 258
Lines 26614 26618 +4
==========================================
- Hits 22441 22437 -4
- Misses 4173 4181 +8 ☔ View full report in Codecov by Sentry. |
Hywan
approved these changes
Jul 10, 2024
… has been edited or removed
…Update` to `TimelineInner` This will make testing easier.
…after cancelling a local echo
bnjbvr
force-pushed
the
bnjbvr/timeline-day-divider-read-marker-off
branch
from
034acb3
to
c0590de
Compare
…as `handle_fully_read_marker`
bnjbvr
force-pushed
the
bnjbvr/timeline-day-divider-read-marker-off
branch
from
c0590de
to
89864c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3361 polish.