tests(timeline): make use of the EventFactory more
#3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m_event` They're the same picture.</meme>
This is `TimelineInner::add_events_at` with fixed parameters.
Callers can make use of the `EventFactory` which is easier to understand IMO, and that avoids a special testing function just for this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3673 +/- ##
==========================================
- Coverage 84.31% 84.30% -0.01%
==========================================
Files 259 259
Lines 26720 26726 +6
==========================================
+ Hits 22529 22532 +3
- Misses 4191 4194 +3 ☔ View full report in Codecov by Sentry. |
…ine::handle_live_reaction` The `EventFactory` is improved to support creating those events too, reducing the number of custom events creators everywhere.
The `EventFactory` can build events with a specific `event_id` already.
…ne::handle_live_reaction`
bnjbvr
force-pushed
the
bnjbvr/timeline-testing
branch
from
1057223
to
eec9128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestTimelinehad lots and lots of custom methods for creating test events and handling them immediately. Since theEventFactoryhelper makes it possible to easily create events, there's no need to repeat those responsibilities in the timeline testing code itself, and we can make more use of theEventFactoryinstead.There's much more to do there; ideally, we'd get rid of most of
TestTimeline::handle_methods (we'd keephandle_live_events), as well asEventBuilderentirely, which API isn't flexible at all. Could be some nice and fun good-first-bugs 😎