Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: get rid of custom fork of openidconnect-rs #3762

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jul 25, 2024

There's a published 4.0.0-alpha.2 version that compiles and doesn't require the custom changes we needed.

Part of #3742.

There's a published 4.0.0-alpha.2 version that compiles and doesn't
require the custom changes we needed.

Part of #3742.
@bnjbvr bnjbvr requested a review from a team as a code owner July 25, 2024 10:59
@bnjbvr bnjbvr requested review from poljar and removed request for a team July 25, 2024 10:59
@bnjbvr bnjbvr enabled auto-merge (rebase) July 25, 2024 11:02
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, under the assumption that them bindings compile.

@bnjbvr bnjbvr merged commit 5cd4462 into main Jul 25, 2024
40 checks passed
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (2eb6930) to head (08b8310).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3762      +/-   ##
==========================================
- Coverage   84.08%   84.06%   -0.03%     
==========================================
  Files         260      260              
  Lines       27031    27031              
==========================================
- Hits        22730    22723       -7     
- Misses       4301     4308       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr deleted the bnjbvr/remove-custom-fork-of-openidconnect branch July 25, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants