Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(room_preview): Add heroes and compute display name #4289

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

jmartinesp
Copy link
Contributor

This is needed to fully replace the invited_room API with the RoomPreview one.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@jmartinesp jmartinesp requested a review from a team as a code owner November 19, 2024 08:08
@jmartinesp jmartinesp requested review from poljar and removed request for a team November 19, 2024 08:08
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.04%. Comparing base (0b16d48) to head (0705b88).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4289      +/-   ##
==========================================
+ Coverage   85.02%   85.04%   +0.02%     
==========================================
  Files         274      274              
  Lines       30107    30114       +7     
==========================================
+ Hits        25599    25611      +12     
+ Misses       4508     4503       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Velin92
Copy link
Member

Velin92 commented Nov 19, 2024

This works on iOS!

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem sensible, but those changelog entries are a bit terse.

Remember that the category, the thing inside the brackets, room_preview will be gone once we generate the changelog. So the entry will look like:

  • Add heroes for known rooms
  • Compute display name

And people will be left wondering what this is about.

@jmartinesp
Copy link
Contributor Author

Remember that the category, the thing inside the brackets, room_preview will be gone once we generate the changelog

Oh, I didn't know that! Yeah, I'll tweak the commit messages then 😅 .

@jmartinesp jmartinesp force-pushed the feat/room-preview-add-heroes-and-computed-name branch from 27f4989 to 0705b88 Compare November 19, 2024 14:54
@jmartinesp jmartinesp enabled auto-merge (rebase) November 19, 2024 14:55
@poljar
Copy link
Contributor

poljar commented Nov 19, 2024

Remember that the category, the thing inside the brackets, room_preview will be gone once we generate the changelog

Oh, I didn't know that! Yeah, I'll tweak the commit messages then 😅 .

You can check out what will be generated using the cargo xtask release weekly-report command

@jmartinesp jmartinesp merged commit 0af53e9 into main Nov 19, 2024
40 checks passed
@jmartinesp jmartinesp deleted the feat/room-preview-add-heroes-and-computed-name branch November 19, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants