-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event cache): enable persistent storage by default 😎 #4308
base: main
Are you sure you want to change the base?
Conversation
4fc22de
to
ddbfc98
Compare
ddbfc98
to
9a452bd
Compare
9a452bd
to
baafadc
Compare
For what it's worth, to observers of this PR: this is being split, redesigned and reviewed in several smaller PRs, which all link to this one. This PR might be repurposed to represent the final step of the work done here, at some point. |
374a421
to
1473d60
Compare
Is it useful to keep this PR open? |
I think I can repurpose it to become the "enable storage by default", by removing a few commits in there :-) |
1473d60
to
e9bc43a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4308 +/- ##
========================================
Coverage 86.14% 86.14%
========================================
Files 291 291
Lines 34308 34165 -143
========================================
- Hits 29553 29431 -122
+ Misses 4755 4734 -21 ☔ View full report in Codecov by Sentry. |
e9bc43a
to
07516cf
Compare
And don'y rely on the `Paginator`. This simplifies the code a bit, avoids a few methods on the `Paginator`, and makes it more straightforward the pagination happens.
Also the tests, they were not quite useful to port to the new mechanism because they made little sense.
…e::Room` This was only used to retrieve events cached in the timeline_queue().
07516cf
to
ac496f3
Compare
f5ccfe4
to
b7f6b19
Compare
This is now ready for review, as it passes all the tests on my machine (and hopefully in CI too!). But we're likely not going to merge this any time soon, as it removes the feature toggle for the event cache's persisted storage. Instead, we'll likely keep the feature toggle for a bit (exact period TBD: one release? some weeks? something that we'll discuss internally), to avoid having to revert a large PR in case things go awfully bad. |
This implements the following parts of #3280 (comment):
For getting a nice demo in the
multiverse
client, a few shortcuts have been taken in the last commit, but these should be relatively easy to solve.The demo shows the following:
Screencast.From.2024-11-21.18-09-05.mp4
More to come next week.