fix(sdk): Improve performance of RoomEvents::maybe_apply_new_redaction
#4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on`.
This patch improves the performance of
`RoomEvents::maybe_apply_new_redaction`. This method deserialises
all the events it receives, entirely. If the event is not an
`m.room.redaction`, then the method returns early. Most of the time,
the event is deserialised for nothing because most events aren't of kind
`m.room.redaction`!
This patch first uses `Raw::get_field("type")` to detect the type of
the event. If it's a `m.room.redaction`, then the event is entirely
deserialized, otherwise the method returns.
When running the `test_lazy_back_pagination` from
matrix-org#4594 with 10'000
events, prior to this patch, this method takes 11% of the execution
time. With this patch, this method takes 2.5%.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4616 +/- ##
=======================================
Coverage 85.73% 85.73%
=======================================
Files 291 291
Lines 33309 33311 +2
=======================================
+ Hits 28557 28559 +2
Misses 4752 4752 ☔ View full report in Codecov by Sentry. |
|
Nice. This calls for a deserialization cache, because we keep deserializing events all over the place… |
|
Indeed. I was working on this but stopped due to lack of time, but it's definitely something that may improve the performance. |
Hywan
added a commit
to Hywan/matrix-rust-sdk
that referenced
this pull request
Feb 4, 2025
This patch adds matrix-org#4601, matrix-org#4608, matrix-org#4612 and matrix-org#4616 in their respective `CHANGELOG.md`s. +
Hywan
added a commit
to Hywan/matrix-rust-sdk
that referenced
this pull request
Feb 4, 2025
This patch adds matrix-org#4601, matrix-org#4608, matrix-org#4612 and matrix-org#4616 in their respective `CHANGELOG.md`s.
Hywan
added a commit
that referenced
this pull request
Feb 4, 2025
23 tasks
toger5
pushed a commit
to toger5/matrix-rust-sdk
that referenced
this pull request
Feb 15, 2025
This patch adds matrix-org#4601, matrix-org#4608, matrix-org#4612 and matrix-org#4616 in their respective `CHANGELOG.md`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the performance of
RoomEvents::maybe_apply_new_redaction. This method deserialises all the events it receives, entirely. If the event is not anm.room.redaction, then the method returns early. Most of the time, the event is deserialised for nothing because most events aren't of kindm.room.redaction!This patch first uses
Raw::get_field("type")to detect the type of the event. If it's am.room.redaction, then the event is entirely deserialised, otherwise the method returns.When running the
test_lazy_back_paginationfrom#4594 with 10'000 events, prior to this patch, this method takes 11% of the execution time. With this patch, this method takes 2.5%.
Call tree before this patch:
After this patch:
EventCachestorage #3280