chore(sdk): Remove RoomEventCacheUpdate::Clear
#4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added a commit
to Hywan/matrix-rust-sdk
that referenced
this pull request
Feb 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4627 +/- ##
==========================================
- Coverage 85.70% 85.69% -0.02%
==========================================
Files 292 292
Lines 33406 33409 +3
==========================================
- Hits 28632 28630 -2
- Misses 4774 4779 +5 ☔ View full report in Codecov by Sentry. |
Hywan
added a commit
to Hywan/matrix-rust-sdk
that referenced
this pull request
Feb 5, 2025
Hywan
force-pushed
the
fix-sdk-event-cache-clear
branch
from
9476b3f to
e467f1e
Compare
This patch removes the `Clear` variant of the `RoomEventCacheUpdate` enum. This one is not needed anymore since we have `UpdateTimelineEvents` which contains updates as `Vec<VectorDiff<_>>`. `VectorDiff` _has_ a `Clear` variant. It resulted in a double clear every time. This patch updates `RoomEventCacheInner::reset` and `RoomEventCacheInner::with_events_mut` to annotate them with a `#[must_use]`. Since they return the updates as `VectorDiff`s, they **must** be broadcasted/propagated somewhere, likely with `RoomEventCacheUpdate`. This mechanism ensures to not miss updates.
Hywan
force-pushed
the
fix-sdk-event-cache-clear
branch
from
e467f1e to
55b6c1a
Compare
stefanceriu
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the
Clearvariant of theRoomEventCacheUpdateenum. This one is not needed anymore since we haveUpdateTimelineEventswhich contains updates asVec<VectorDiff<_>>.VectorDiffhas aClearvariant. It resulted in a double clear every time.This patch updates
RoomEventCacheInner::resetandRoomEventCacheInner::with_events_mutto annotate them with a#[must_use]. Since they return the updates asVectorDiffs, they must be broadcasted/propagated somewhere, likely withRoomEventCacheUpdate. This mechanism ensures to not miss updates.EventCachestorage #3280