-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event cache): deduplicate using a store when available #4662
Conversation
The YAGNI crew strikes again.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4662 +/- ##
==========================================
+ Coverage 85.74% 85.76% +0.01%
==========================================
Files 292 292
Lines 33723 33733 +10
==========================================
+ Hits 28917 28932 +15
+ Misses 4806 4801 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greeeeaaat! Can we have a couple of tests for the store based deduplicator? We already test filter_duplicated_events
but one test to ensure the behaviour of retain
works as expected would be nice :-). Thanks!
Based on the glorious work of #4659 and #4656, this introduces a new way to deduplicate events, whether we have enabled storage or not, using a plain old sum type 🤓 When storage is enabled by default for everyone, we can get rid of the
BloomFilterDeduplicator
and replaceDeduplicator
with the store-based one.Part of #3280.