feat(common): Update::RemoveChunk emits VectorDiff::Remove
#4696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates `Update::RemoveChunk` to emit `VectorDiff::Remove`. Until now, `RemoveChunk` was expecting the chunk to be empty, because it is how it is used so far. However, with matrix-org#4694, it can change rapidly.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4696 +/- ##
==========================================
- Coverage 85.90% 85.88% -0.02%
==========================================
Files 292 292
Lines 33909 33910 +1
==========================================
- Hits 29129 29125 -4
- Misses 4780 4785 +5 ☔ View full report in Codecov by Sentry. |
…Diff::Remove`. This patch adds a test ensuring that `AsVector` generates the correct `VectorDiff::Remove` when a non-empty chunk is removed.
Hywan
force-pushed
the
feat-common-linked-chunk-as-vector-remove-chunk
branch
from
22980b2 to
6a24d68
Compare
jmartinesp
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
Update::RemoveChunkto emitVectorDiff::Remove. Until now,RemoveChunkwas expecting the chunk to be empty, because it is how it is used so far. However, with #4694, it can change rapidly. It's better to be robust whatever the future will look like.EventCachestorage #3280