feat(event cache): automatically shrink a room's linked chunk when all subscribers are gone #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4703 +/- ##
==========================================
- Coverage 85.94% 85.94% -0.01%
==========================================
Files 290 290
Lines 33892 33942 +50
==========================================
+ Hits 29130 29170 +40
- Misses 4762 4772 +10 ☔ View full report in Codecov by Sentry. |
Hywan
reviewed
Feb 21, 2025
Comment on lines
78
to
82
| // I hear you from the future: "but, spawning a detached task in a drop | ||
| // implementation is real bad! Maybe there will be multiple shrinks | ||
| // happening at the same time, and that's bad!". However, this can't | ||
| // happen, because the whole `state` variable is guarded by a fair lock, | ||
| // which will run queries in the order they happen. Should be fine™. |
There was a problem hiding this comment.
You forgot to explain why you need to spawn here. It's because drop cannot be async, and you're doing async operations.
There was a problem hiding this comment.
Yep, introduced a mechanism with one (1) task listening forever in the event cache, that should be more sound.
bnjbvr
force-pushed
the
bnjbvr/unload-after-all-subscriptions-gone
branch
2 times, most recently
from
291665b to
dcf80a6
Compare
…isteners are left
bnjbvr
force-pushed
the
bnjbvr/unload-after-all-subscriptions-gone
branch
2 times, most recently
from
4674ba3 to
c78fc0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #4694.
Every subscriber to a
RoomEventCachenow gets an atomic counter of the number of listeners to updates to this room. When the count reaches 0, the listener will notify a task (living at theEventCachelevel, to avoid having one task per room) that the room's linked chunk may be shrunk, if the number of listeners is still 0.Part of #3280.