Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event cache): don't auto-shrink if the sync returned 0 events #4719

Closed
wants to merge 1 commit into from

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Feb 25, 2025

Tests to be written.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.09%. Comparing base (3e3bff7) to head (5fe3fb4).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4719      +/-   ##
==========================================
+ Coverage   86.08%   86.09%   +0.01%     
==========================================
  Files         290      290              
  Lines       34072    34072              
==========================================
+ Hits        29331    29335       +4     
+ Misses       4741     4737       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr
Copy link
Member Author

bnjbvr commented Mar 3, 2025

I am now convinced this is incorrect: if the sync included a gap but no events, we may be rendering events from before the gap in the timeline, but not the gap, leading to the impression that some events (those that would be returned by resolving the gap) have been lost by the app. Closing for now.

@bnjbvr bnjbvr closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant