Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New simulations #134

Merged
merged 6 commits into from
Feb 21, 2024
Merged

New simulations #134

merged 6 commits into from
Feb 21, 2024

Conversation

jgallowa07
Copy link
Member

This PR:

  • Addresses the simulations outlined in Simulations outline #125.
  • Adds a fully polished notebook that we've added to the documentation with simulated data, fitting, and cross-validation as requested in Add Simulations and Spike analysis to documentation #132.
  • Removes Jax 64-bit precision accuracy. I've noted that it has very little impact on the simulations, and should thus be off by default to follow JAX best-practices
  • It's adds new functionality ModelCollection.add_validation_loss and Model.get_df_loss methods to streamline cross-validation analyses.
  • Testing for the new validation methods.
  • Specifies a zero beta ridge penalty when computing the Model.loss, this has no effective behavior impact, mainly for code-readability.
  • fixes other minor typos in the code I came across.

@jgallowa07 jgallowa07 merged commit 37e55f4 into main Feb 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant