Add keyboard commands to watch mode #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes watch mode interactive. It now understands these keys: - Press ENTER to run all tests - Press "q" to quit To do this, I start another background thread that listens for key presses. When a key is pressed, the thread posts a `:keypress` event to the event loop. The event loop then takes an appropriate action. Because they keypress listener is running in a thread separate from the file system listener, that means the watcher is still able to detect changes to files and auto-run tests. The event loop funnels all of these events into a single thread of execution.
mattbrictson
commented
Feb 22, 2024
Comment on lines
+79
to
+80
| rescue Interrupt | ||
| retry |
There was a problem hiding this comment.
🗒️ If the user presses ctrl-c to interrupt a slow test, we want the test to be canceled, but the watcher to continue running. That's why the Interrupt exception is ignored here and the keypress loop continues.
If a test is not running and the user presses ctrl-c, the event loop in the main (foreground) thread will exit with an un-rescued Interrupt exception and die, and the entire watcher process will exit, effectively killing any background threads. So we don't need to explicitly handle that scenario here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes watch mode interactive. It now understands these keys:
To do this, I start another background thread that listens for key presses. When a key is pressed, the thread posts a
:keypressevent to the event loop. The event loop then takes an appropriate action.Because they keypress listener is running in a thread separate from the file system listener, that means the watcher is still able to detect changes to files and auto-run tests. The event loop funnels all of these events into a single thread of execution.