Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-56058] Multi arch builds support #20

Merged
merged 2 commits into from
Feb 29, 2024
Merged

[MM-56058] Multi arch builds support #20

merged 2 commits into from
Feb 29, 2024

Conversation

streamer45
Copy link
Contributor

Summary

Adding support for building and releasing multi-arch (currently amd64 and arm64) docker images.

Dev builds for this branch -> https://hub.docker.com/layers/mattermost/calls-transcriber/v0.2.0-dev2/images/sha256-56dd739a737defbc299496df6538d8d92cda8a5a86566115c1786e17252710ce?context=explore

Ticket Link

https://mattermost.atlassian.net/browse/MM-56058

@streamer45 streamer45 added 2: Dev Review Requires review by a core committer Do Not Merge Should not be merged until this label is removed labels Feb 24, 2024
@streamer45 streamer45 added this to the v0.2.0 milestone Feb 24, 2024
@streamer45 streamer45 requested a review from cpoile February 24, 2024 02:57
@streamer45 streamer45 self-assigned this Feb 24, 2024
cpoile
cpoile previously approved these changes Feb 27, 2024
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looking forward to running on arm!

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! Let's get it merged, then I can merge it into live-captions and I can finally locally test. 🎉

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 27, 2024
@streamer45 streamer45 removed the Do Not Merge Should not be merged until this label is removed label Feb 28, 2024
@streamer45 streamer45 merged commit cc2f4d0 into master Feb 29, 2024
2 checks passed
@streamer45 streamer45 deleted the MM-56058 branch February 29, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants