Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-61426] Bump to new pionv4 based client #34

Merged
merged 4 commits into from
Jan 7, 2025
Merged

[MM-61426] Bump to new pionv4 based client #34

merged 4 commits into from
Jan 7, 2025

Conversation

streamer45
Copy link
Contributor

Summary

Updating the client to the new pion v4 based one. Will then prepare a dev image to test on e2e pipeline on the plugin side.

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Dec 19, 2024
@streamer45 streamer45 requested a review from cpoile December 19, 2024 23:57
@streamer45 streamer45 self-assigned this Dec 19, 2024
cpoile
cpoile previously approved these changes Dec 20, 2024
@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Dec 20, 2024
@streamer45 streamer45 added this to the v0.6.0 milestone Dec 20, 2024
* Persist logs to scoped data path

* Fix test setup

* Fix tests
@streamer45
Copy link
Contributor Author

Stale review 😬

cpoile
cpoile previously approved these changes Jan 7, 2025
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@streamer45
Copy link
Contributor Author

Forgot one little thing.

@streamer45 streamer45 requested a review from cpoile January 7, 2025 12:48
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@streamer45 streamer45 merged commit 54e7138 into master Jan 7, 2025
2 checks passed
@streamer45 streamer45 deleted the MM-61426 branch January 7, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants