Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiarch build #37

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix multiarch build #37

merged 1 commit into from
Feb 28, 2025

Conversation

streamer45
Copy link
Contributor

Summary

Debugging multi-arch docker builds is always fun. Hopefully, this is enough.

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Feb 28, 2025
@streamer45 streamer45 self-assigned this Feb 28, 2025
@streamer45 streamer45 added this to the v0.6.1 milestone Feb 28, 2025
@@ -22,7 +22,7 @@ FROM --platform=$TARGETPLATFORM golang:${GO_VERSION}-bookworm AS builder
# Install patch
# hadolint ignore=DL3008
RUN apt-get update && \
apt-get install --no-install-recommends -y patch
apt-get install --no-install-recommends -y patch ccache
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the fix, but it helps to speed up whisper.cpp compilation.

@streamer45 streamer45 requested a review from cpoile February 28, 2025 16:38
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 28, 2025
@streamer45 streamer45 merged commit d623cd2 into master Feb 28, 2025
2 checks passed
@streamer45 streamer45 deleted the fix-multiarch-build branch February 28, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants