MM-59761 Add tests for i18n functionality #8510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwilander seems test aren't passing. Looks like some sort of conflict with the i18n extract tool (likely looking for the IDs from the tests) |
|
Ack - I'll see if I can get it to ignore the test file |
another possible option would be to use id's already present in the translations |
jwilander
force-pushed
the
mm-59761_i18n-tests
branch
from
0953d4c to
995ee2f
Compare
|
@Willyfrog @Rajat-Dabade ready for review |
Rajat-Dabade
approved these changes
Jan 30, 2025
|
Re-assigning review to @pvev since Guillermo will be out |
jwilander
added
4: Reviews Complete
larkox
pushed a commit
that referenced
this pull request
Feb 4, 2025
* test: Add tests for i18n functionality * Remove test causing i18n ci check failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add tests for i18n files.
Ticket Link
https://mattermost.atlassian.net/browse/MM-59761
Checklist
E2E iOS tests for PR.Device Information
This PR was tested on: n/a
Screenshots
n/a
Release Note