Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-17] Fix mention notifications and label/milestone RHS display #721

Merged
merged 6 commits into from
Jan 12, 2024
Merged

[MM-17] Fix mention notifications and label/milestone RHS display #721

merged 6 commits into from
Jan 12, 2024

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

  1. Mention notifications not working.
  2. Labels and milestones not displayed in the RHS.

What to test?

  • Labels and milestones are properly displayed in the RHS.
  • Getting DM notifications for mentions.

Steps to reproduce:

  • Labels and milestones:
  1. Connect your GitHub account.
  2. Create a PR on Github and add labels/milestones to it.
  3. Open RHS for open PRs on Mattermost.
  • DM notification:
  1. Connect your GitHub account.
  2. Create a webhook.
  3. You should get notified in GitHub bot DM when someone else mentions/assigns you in a PR/Issue.

Ticket Link

N/A

@raghavaggarwal2308
[MM-17] Fix issues in release 2.2.0:
80f5d49 
1. Mention notifications not working.
2. Labels and milestones not getting displayed in the RHS.
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5aa2450) 15.79% compared to head (ea87542) 15.78%.

Files Patch % Lines
server/plugin/plugin.go 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
- Coverage   15.79%   15.78%   -0.01%     
==========================================
  Files          15       15              
  Lines        5767     5770       +3     
==========================================
  Hits          911      911              
- Misses       4814     4817       +3     
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hanzei
hanzei requested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @raghavaggarwal2308

server/plugin/plugin.go Outdated Show resolved Hide resolved
webapp/src/components/sidebar_right/github_items.tsx Show resolved Hide resolved
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Dec 18, 2023
@raghavaggarwal2308
Copy link
Contributor Author

@hanzei Gentle reminder for re-review

hanzei
hanzei approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

server/plugin/plugin.go Outdated Show resolved Hide resolved
@raghavaggarwal2308 @hanzei
Review fix
67abeac 
Co-authored-by: Ben Schumacher <[email protected]>
@hanzei hanzei added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Jan 4, 2024
arush-vashishtha
arush-vashishtha approved these changes Jan 5, 2024
View reviewed changes
Copy link

@arush-vashishtha arush-vashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR for the followings,

  • Labels and milestones added to a PR or issue are properly displayed in the RHS.
  • Getting DM notifications from Github bot for the mentions and assigned PR and issues.

Everything is working fine, Approved.
cc @AayushChaudhary0001

mickmister
mickmister approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some comments on naming from the recent LHS request feature

server/plugin/graphql/lhs_request.go Outdated Show resolved Hide resolved
server/plugin/graphql/lhs_request.go Outdated Show resolved Hide resolved
server/plugin/graphql/lhs_request.go Outdated Show resolved Hide resolved
@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 9, 2024
@raghavaggarwal2308
Copy link
Contributor Author

@mickmister Fixed the comments added by you

@avas27JTG avas27JTG merged commit 2608197 into mattermost:master Jan 12, 2024
9 checks passed
@avas27JTG avas27JTG deleted the MM-17 branch January 12, 2024 09:06
@mickmister mickmister changed the title [MM-17] Fix issues in release 2.2.0 [MM-17] Fix mention notifications and label/milestone RHS display Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmister mickmister mickmister approved these changes

@hanzei hanzei hanzei approved these changes

@arush-vashishtha arush-vashishtha arush-vashishtha approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@raghavaggarwal2308 @codecov-commenter @mickmister @hanzei @arush-vashishtha @avas27JTG