Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-408]: Made username clickable in RHS PRs/Issues #830

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

Make username clickable in RHS PRs/Issues

Ticket Link

Fixes #408

Screenshots

Existing

Screenshot from 2024-09-26 17-38-13

Updated

Screenshot from 2024-09-26 17-37-04

@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 10, 2024
@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.4.0 milestone Dec 2, 2024
@Kshitij-Katiyar Kshitij-Katiyar modified the milestones: v2.4.0, v2.5.0 Jan 9, 2025
@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Jan 16, 2025
@Kshitij-Katiyar Kshitij-Katiyar modified the milestones: v2.5.0, v2.4.0 Jan 30, 2025
@AayushChaudhary0001
Copy link

While testing this PR, I found an issue that the user profile page on clicking is opening on the same tab and not in a new one.

Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested and the above issue is resolved now. The username is now clickable and user is redirected to the clicked user's profile, LGTM. Approved.

@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 30, 2025
@raghavaggarwal2308 raghavaggarwal2308 merged commit 370b803 into master Jan 30, 2025
11 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-408 branch January 30, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make username clickable in RHS PRs/Issues
4 participants