Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testcase for some functions in server/api.go #844

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Nov 4, 2024

Summary

Added unit test cases for the following functions in server/api.go file

  • GetToken
  • UpdateSettings
  • GetGitHubUser
  • ParseRepo
  • CheckPluginRequest

@Kshitij-Katiyar Kshitij-Katiyar added the 2: Dev Review Requires review by a core committer label Nov 4, 2024
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Nov 4, 2024
@Kshitij-Katiyar Kshitij-Katiyar changed the title added testcase for some functions in server/api.go Added testcase for some functions in server/api.go Nov 4, 2024
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from server_unit_testcase_template to master December 5, 2024 06:44
Copy link
Contributor

@raghavaggarwal2308 raghavaggarwal2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kshitij-Katiyar There are a lot of unrelated changes in this PR, can you please check?

@Kshitij-Katiyar
Copy link
Contributor Author

@raghavaggarwal2308 I have resolved the conflicts, please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants