Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testcase for some functions in server/command.go #845

Open
wants to merge 10 commits into
base: add_server/api.go_testcases
Choose a base branch
from
Open

Added testcase for some functions in server/command.go #845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8c8df81
addede testcase for some functions in server/command.go
Kshitij-Katiyar Nov 4, 2024
5631584
Merge branch 'add_server/api.go_testcases' of github.com:mattermost/m…
Kshitij-Katiyar Nov 4, 2024
df4695f
Merge branch 'add_server/api.go_testcases' of github.com:mattermost/m…
Kshitij-Katiyar Nov 4, 2024
1b56537
Updated the getMutedUser function to return proper response
Kshitij-Katiyar Nov 7, 2024
a4e92f0
added logs to the new error check
Kshitij-Katiyar Nov 7, 2024
f7abf21
fixed grammar of error msgs in command.go
Kshitij-Katiyar Nov 11, 2024
5a4924e
Merge branch 'master' of github.com:mattermost/mattermost-plugin-gith…
Kshitij-Katiyar Jan 16, 2025
7c944a1
review fixes
Kshitij-Katiyar Jan 16, 2025
aed774f
Merge branch 'add_server/api.go_testcases' of github.com:mattermost/m…
Kshitij-Katiyar Jan 16, 2025
cbce6eb
updated muted list testcases
Kshitij-Katiyar Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions server/plugin/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,23 +141,28 @@ func (p *Plugin) postCommandResponse(args *model.CommandArgs, text string) {
p.client.Post.SendEphemeralPost(args.UserId, post)
}

func (p *Plugin) getMutedUsernames(userInfo *GitHubUserInfo) []string {
func (p *Plugin) getMutedUsernames(userInfo *GitHubUserInfo) ([]string, error) {
var mutedUsernameBytes []byte
err := p.store.Get(userInfo.UserID+"-muted-users", &mutedUsernameBytes)
if err != nil {
return nil
return nil, err
}
mutedUsernames := string(mutedUsernameBytes)
var mutedUsers []string
if len(mutedUsernames) == 0 {
return mutedUsers
return mutedUsers, nil
}
mutedUsers = strings.Split(mutedUsernames, ",")
return mutedUsers
return mutedUsers, nil
}

func (p *Plugin) handleMuteList(_ *model.CommandArgs, userInfo *GitHubUserInfo) string {
mutedUsernames := p.getMutedUsernames(userInfo)
mutedUsernames, err := p.getMutedUsernames(userInfo)
if err != nil {
p.client.Log.Error("error occurred getting muted users.", "UserID", userInfo.UserID, "Error", err)
return "An error occurred getting muted users. Please try again later"
}

var mutedUsers string
for _, user := range mutedUsernames {
mutedUsers += fmt.Sprintf("- %v\n", user)
Expand All @@ -178,7 +183,12 @@ func contains(s []string, e string) bool {
}

func (p *Plugin) handleMuteAdd(_ *model.CommandArgs, username string, userInfo *GitHubUserInfo) string {
mutedUsernames := p.getMutedUsernames(userInfo)
mutedUsernames, err := p.getMutedUsernames(userInfo)
if err != nil {
p.client.Log.Error("error occurred getting muted users.", "UserID", userInfo.UserID, "Error", err)
return "An error occurred getting muted users. Please try again later"
}

if contains(mutedUsernames, username) {
return username + " is already muted"
}
Expand All @@ -195,7 +205,7 @@ func (p *Plugin) handleMuteAdd(_ *model.CommandArgs, username string, userInfo *
mutedUsers = username
}

_, err := p.store.Set(userInfo.UserID+"-muted-users", []byte(mutedUsers))
_, err = p.store.Set(userInfo.UserID+"-muted-users", []byte(mutedUsers))
if err != nil {
return "Error occurred saving list of muted users"
}
Expand All @@ -204,11 +214,16 @@ func (p *Plugin) handleMuteAdd(_ *model.CommandArgs, username string, userInfo *
}

func (p *Plugin) handleUnmute(_ *model.CommandArgs, username string, userInfo *GitHubUserInfo) string {
mutedUsernames := p.getMutedUsernames(userInfo)
mutedUsernames, err := p.getMutedUsernames(userInfo)
if err != nil {
p.client.Log.Error("error occurred getting muted users.", "UserID", userInfo.UserID, "Error", err)
return "An error occurred getting muted users. Please try again later"
}

userToMute := []string{username}
newMutedList := arrayDifference(mutedUsernames, userToMute)

_, err := p.store.Set(userInfo.UserID+"-muted-users", []byte(strings.Join(newMutedList, ",")))
_, err = p.store.Set(userInfo.UserID+"-muted-users", []byte(strings.Join(newMutedList, ",")))
if err != nil {
return "Error occurred unmuting users"
}
Expand Down
Loading
Loading