Added testcase for more functions in server/command.go #846
+354
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attermost-plugin-github into add_server/command.go_testcases
…attermost-plugin-github into add_server/command.go_testcases
raghavaggarwal2308
changed the title
wiggin77
approved these changes
Dec 10, 2024
raghavaggarwal2308
requested changes
Dec 19, 2024
| setup: func() { | ||
| mockKvStore.EXPECT().Get(SubscriptionsKey, gomock.Any()).DoAndReturn(func(key string, value **Subscriptions) error { | ||
| *value = &Subscriptions{ | ||
| Repositories: map[string][]*Subscription{ |
There was a problem hiding this comment.
create a util for this, a similar thing is used below as well
There was a problem hiding this comment.
these values are too nested and compilcated. Making a util will be difficult for them
…ub into add_api/command.go_testcases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added testcase for the following api/command.go functions:
Parent PR
#845