Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply and enforce file-level license headers #869

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lieut-data
Copy link
Member

Summary

Use mattermost-govet and eslint's header/header to ensure each file begins with the appropriate header, then fix all instances.

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.

Note that this renames LICENSE to LICENSE.txt purely to align on the copyright messaging across repos.

Ticket Link

None

Use `mattermost-govet` and `eslint`'s `header/header` to ensure each
file begins with the appropriate header, then fix all instances.

```
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
```

Note that this renames `LICENSE` to `LICENSE.txt` purely to align on the
copyright messaging across repos.
@lieut-data lieut-data force-pushed the updated-license-header branch from d2b837c to b7ea2e6 Compare January 21, 2025 08:10
Comment on lines +19 to +20
with:
golang-version: "1.22"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unique in all the others in that I couldn't get mattermost-govet as built to run with go vet, it seems because the toolchain version installed was different than go.mod.

Aligning this here fixed the issue... but that technically potentially changes the Go version we're building the core plugin with (even though it should have been that way), and I'm surfacing here for visibility.

Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants