This repository has been archived by the owner on Jan 20, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, addnext would try to unconditionally add at index one into a
queue. This panicked if the queue was empty. Added two protections, one
that checks the index in the InsertTrack function, the other in the
addnext command itself to insert at zero if the queue is empty.
Before submitting this pull request, please acknowledge that you have done the following:
What type of pull request is this?
Description of your pull request:
Fixes that
addnext
fails on an empty queue. This is because it unconditionally tries to insert at index one, which is out of range for an empty queue. Added a check to return an error if an invalid index is passed. To fix the bug itself, I added an extra case toaddnext
that inserts at zero instead.I couldn't think of a way to write unit tests for this as it would require passing an actual url to
addnext
. Running it seems to work now, though.