Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MauticFactory::getLogger. #14463

Open
wants to merge 2 commits into
base: 6.x
Choose a base branch
from
Open

Remove MauticFactory::getLogger. #14463

wants to merge 2 commits into from
+1 −47

Conversation

biozshock
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🟢
BC breaks? (use the c.x branch) 🟢
Automated tests included? 🟢

Description

Remove deprecated MauticFactory::getLogger.

📋 Steps to test this PR:

  1. Check tests were okay. Only usages were found there.

patrykgruszka
patrykgruszka approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@patrykgruszka patrykgruszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the project files for usage of MauticFactory::getLogger. The usage in tests was removed. The CI test fails only for one test that is not related to this PR. Looks good 👍

escopecz
escopecz approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this method to be used anywhere either 👍 Thank you!

@escopecz escopecz added this to the 6.0 milestone Jan 17, 2025
@escopecz escopecz added refactoring The change does not change behavior but improves the code code-review-passed PRs which have passed code review ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykgruszka patrykgruszka patrykgruszka approved these changes

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged refactoring The change does not change behavior but improves the code
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@biozshock @escopecz @patrykgruszka