Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uploading header twice if DataFrame is empty, fixes #47 #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix uploading header twice if DataFrame is empty, fixes #47 #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c4da47
fix uploading header twice if DataFrame is empty, fixes #47
22764636 Nov 8, 2019
e68a9b5
correct behaviour when uploading empty dataframe
22764636 Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions df2gspread/df2gspread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def upload(df, gfile="/New Spreadsheet", wks_name=None,
'''
Upload given Pandas DataFrame to Google Drive and returns
gspread Worksheet object

:param df: Pandas DataFrame
:param gfile: path to Google Spreadsheet or gspread ID
:param wks_name: worksheet name
Expand Down Expand Up @@ -58,9 +57,7 @@ def upload(df, gfile="/New Spreadsheet", wks_name=None,
:type new_sheet_dimensions: tuple
:returns: gspread Worksheet
:rtype: class 'gspread.models.Worksheet'

:Example:

>>> from df2gspread import df2gspread as d2g
>>> import pandas as pd
>>> df = pd.DataFrame([1 2 3])
Expand Down Expand Up @@ -120,13 +117,14 @@ def upload(df, gfile="/New Spreadsheet", wks_name=None,

# Addition of col names
if col_names:
cell_list = wks.range('%s%s:%s%s' % (first_col, start_row, last_col, start_row))
cell_list = wks.range('%s%s:%s%s' % (
first_col, start_row, last_col, start_row))
for idx, cell in enumerate(cell_list):
cell.value = df.columns.astype(str)[idx]
wks.update_cells(cell_list)

# Addition of row names
if row_names:
# Addition of row names only if DataFrame not empty
if row_names and len(df.index) != 0:
cell_list = wks.range('%s%s:%s%d' % (
start_col, first_row, start_col, last_idx))
for idx, cell in enumerate(cell_list):
Expand All @@ -136,8 +134,10 @@ def upload(df, gfile="/New Spreadsheet", wks_name=None,

# convert df values to string
df = df.applymap(str)
# Before adding cell values, if DataFrame empty avoid duplicating header
last_idx = first_row if last_idx < int(first_row) else last_idx
# Addition of cell values
cell_list = wks.range('%s%s:%s%d' % (
cell_list = wks.range('%s%s:%s%s' % (
first_col, first_row, last_col, last_idx))
for j, idx in enumerate(df.index):
for i, col in enumerate(df.columns.values):
Expand All @@ -147,9 +147,9 @@ def upload(df, gfile="/New Spreadsheet", wks_name=None,
wks.update_cells(cell_list)
return wks


def clean_worksheet(wks, gfile_id, wks_name, credentials):
"""DOCS..."""

values = wks.get_all_values()
if values:
df_ = pd.DataFrame(index=range(len(values)),
Expand Down