refactor: Router scopes and permissions #1075
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: N/A
This PR represents a suggestion to how permissions are checked in requests. Before, we were using configuration to determine what permission applies to each route. This is easy to miss and I feel could be simplified by managing
scope
s a bit better in the router.Tl;dr of changes:
Permissions
module andAuthorize
plug have been removedscope
s have been updated so the appropriate plug runs and authorizes the userI find this easier to follow so wanted to present this as an option and open the topic for discussion.
Reviewer Checklist