Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[elixir] feat: fetch dmap worker #49

Merged
merged 8 commits into from
Jun 7, 2022
Merged

[elixir] feat: fetch dmap worker #49

merged 8 commits into from
Jun 7, 2022

Conversation

grejdi-mbta
Copy link
Collaborator

@grejdi-mbta grejdi-mbta commented May 26, 2022 •
edited
Loading

This PR adds a worker for fetching DMAP data from Cubic's cloud storage and uploading them to our 'Incoming' bucket.

@grejdi-mbta
Copy link
Collaborator Author

@paulswartz Feel free to peek in. Still working through the upload to S3 and some small Credo refactors, but overall should be in good shape.

@grejdi-mbta grejdi-mbta force-pushed the gg-1202207406750018-worker-for-fetch-dmap branch from 00e51b0 to 2eabb35 Compare May 26, 2022 22:04
paulswartz
paulswartz reviewed May 28, 2022
View reviewed changes
Copy link
Member

@paulswartz paulswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the sample files have data?

.env.template Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/schema/cubic_dmap_dataset.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/schema/cubic_dmap_dataset.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/utility.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/utility.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/utility.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/workers/fetch_dmap.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/workers/fetch_dmap.ex Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

Coverage of commit 56613b8

Summary coverage rate:
  lines......: 89.8% (368 of 410 lines)
  functions..: 69.1% (152 of 220 functions)
  branches...: no data found

Files changed coverage rate:
                                                           |Lines       |Functions  |Branches    
  Filename                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================
  lib/ex_cubic_ingestion/schema/cubic_dmap_dataset.ex      | 100%      7| 100%     8|    -      0
  lib/ex_cubic_ingestion/schema/cubic_dmap_feed.ex         | 100%      6| 100%     8|    -      0
  lib/ex_cubic_ingestion/schema/cubic_table.ex             |84.6%     13|77.8%     9|    -      0
  lib/ex_cubic_ingestion/validators.ex                     | 100%      5| 100%     4|    -      0
  lib/ex_cubic_ingestion/workers/fetch_dmap.ex             |94.1%     34| 100%     6|    -      0
  lib/ex_cubic_ingestion/workers/schedule_dmap.ex          | 0.0%      1| 0.0%     1|    -      0
  test/support/ex_aws.ex                                   |88.2%     34| 100%     4|    -      0
  test/support/httpoison.ex                                |75.0%      8| 100%     1|    -      0

Download coverage report

@grejdi-mbta grejdi-mbta mentioned this pull request Jun 4, 2022
Open
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

Coverage of commit 68672eb

Summary coverage rate:
  lines......: 90.0% (368 of 409 lines)
  functions..: 69.4% (152 of 219 functions)
  branches...: no data found

Files changed coverage rate:
                                                           |Lines       |Functions  |Branches    
  Filename                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================
  lib/ex_cubic_ingestion/schema/cubic_dmap_dataset.ex      | 100%      7| 100%     8|    -      0
  lib/ex_cubic_ingestion/schema/cubic_dmap_feed.ex         | 100%      6| 100%     8|    -      0
  lib/ex_cubic_ingestion/schema/cubic_table.ex             |84.6%     13|77.8%     9|    -      0
  lib/ex_cubic_ingestion/validators.ex                     | 100%      5| 100%     4|    -      0
  lib/ex_cubic_ingestion/workers/fetch_dmap.ex             |94.1%     34| 100%     6|    -      0
  test/support/ex_aws.ex                                   |88.2%     34| 100%     4|    -      0
  test/support/httpoison.ex                                |75.0%      8| 100%     1|    -      0

Download coverage report

@grejdi-mbta
Copy link
Collaborator Author

should the sample files have data?

Just wanted to have placeholders for now. I will add some in soon.

@grejdi-mbta grejdi-mbta requested a review from paulswartz June 4, 2022 02:25
@grejdi-mbta grejdi-mbta changed the title [elixir] fetch dmap worker [elixir] feat: fetch dmap worker Jun 4, 2022
paulswartz
paulswartz reviewed Jun 6, 2022
View reviewed changes
ex_cubic_ingestion/lib/ex_cubic_ingestion/schema/cubic_dmap_feed.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/validators.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/validators.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/validators.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/validators.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/workers/fetch_dmap.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/lib/ex_cubic_ingestion/workers/fetch_dmap.ex Outdated Show resolved Hide resolved
ex_cubic_ingestion/test/ex_cubic_ingestion/workers/fetch_dmap_test.exs Show resolved Hide resolved
@grejdi-mbta grejdi-mbta force-pushed the gg-1202207406750018-worker-for-fetch-dmap branch from 68672eb to 4d2c2a2 Compare June 6, 2022 19:40
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Coverage of commit 4d2c2a2

Summary coverage rate:
  lines......: 90.0% (368 of 409 lines)
  functions..: 69.4% (152 of 219 functions)
  branches...: no data found

Files changed coverage rate:
                                                           |Lines       |Functions  |Branches    
  Filename                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================
  lib/ex_cubic_ingestion/schema/cubic_dmap_dataset.ex      | 100%      7| 100%     8|    -      0
  lib/ex_cubic_ingestion/schema/cubic_dmap_feed.ex         | 100%      6| 100%     8|    -      0
  lib/ex_cubic_ingestion/schema/cubic_table.ex             |84.6%     13|77.8%     9|    -      0
  lib/ex_cubic_ingestion/validators.ex                     | 100%      5| 100%     4|    -      0
  lib/ex_cubic_ingestion/workers/fetch_dmap.ex             |94.1%     34| 100%     6|    -      0
  test/support/ex_aws.ex                                   |88.2%     34| 100%     4|    -      0
  test/support/httpoison.ex                                |75.0%      8| 100%     1|    -      0

Download coverage report

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Coverage of commit e138d8a

Summary coverage rate:
  lines......: 90.0% (371 of 412 lines)
  functions..: 69.4% (152 of 219 functions)
  branches...: no data found

Files changed coverage rate:
                                                           |Lines       |Functions  |Branches    
  Filename                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================
  lib/ex_cubic_ingestion/schema/cubic_dmap_dataset.ex      | 100%     12| 100%     9|    -      0
  lib/ex_cubic_ingestion/schema/cubic_dmap_feed.ex         | 100%      6| 100%     8|    -      0
  lib/ex_cubic_ingestion/schema/cubic_table.ex             |84.6%     13|77.8%     9|    -      0
  lib/ex_cubic_ingestion/validators.ex                     | 100%      5| 100%     4|    -      0
  lib/ex_cubic_ingestion/workers/fetch_dmap.ex             |93.8%     32| 100%     5|    -      0
  test/support/ex_aws.ex                                   |88.2%     34| 100%     4|    -      0
  test/support/httpoison.ex                                |75.0%      8| 100%     1|    -      0

Download coverage report

@grejdi-mbta grejdi-mbta requested a review from paulswartz June 6, 2022 21:22
paulswartz
paulswartz approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@paulswartz paulswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@grejdi-mbta grejdi-mbta merged commit c47b372 into main Jun 7, 2022
@grejdi-mbta grejdi-mbta deleted the gg-1202207406750018-worker-for-fetch-dmap branch June 7, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulswartz paulswartz paulswartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grejdi-mbta @paulswartz