FEAT: Decrease run-time duration of ODS-QLIK Process #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymarczy
changed the title
grejdi-mbta
reviewed
Nov 7, 2024
src/cubic_loader/qlik/ods_qlik.py
Outdated
| """ | ||
| find all available CDC dfm files for a Snapshot from Archive and Error buckets | ||
| find all available CDC csv.gz files for a Snapshot from Archive bucket |
There was a problem hiding this comment.
Curious why you're dropping Error bucket.
There was a problem hiding this comment.
I dropped it when I was trying to simplify things, I can add it back.
There was a problem hiding this comment.
Up to you. But I think we should have it in there. The glue pipeline is unnecessarily strict so we shouldn't constrain this pipeline because of it.
grejdi-mbta
approved these changes
Nov 7, 2024
I checked it out locally, the only tricky thing is returning a list with everything sorted by the last timestamp of the filename. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change alters the way ods-qlik data is loaded into the dmap-import database.
Previously the ods-qlik data loading steps where:
_historytable_facttable updates.This approach has proven to not be scalable, as the size of the
_historytables and complicated nature of the_facttable query, has resulted in unacceptable long load times.The new process does the following:
_historytable_facttable individually with dataframe objectThe new process completely removes the need for a complicated query to load data from
_historytable to the_facttable and thus dramatically reduces loading time when running the ods-qlik process.The new process is also completely compatible with existing ETL status files.