FIX: WC700 COMP A #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymarczy
commented
Jan 27, 2025
| AND tcm.sales_channel_key = ps.sales_channel_key | ||
| and tcm.payment_type_key = ps.payment_type_key | ||
| WHERE | ||
| tcm.txn_group = 'Product Sales' |
There was a problem hiding this comment.
Had the wrong txn_group
rymarczy
commented
Jan 27, 2025
Comment on lines
+52
to
+53
| "EDW.FAREREV_RECOVERY_TXN", | ||
| "EDW.REASON_DIMENSION", |
There was a problem hiding this comment.
FAREREV_RECOVERY_TXN needed for COMP-C
REASON_DIMENSION needed for COMP-D
grejdi-mbta
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has a new db migration to fix the WC700 Comp-A VIEW.
Also added two additional tables to be imported into dmap-import that are required for WC700 Comp C&D.