FIX: ODS Views and dmap-import sequences #45
Merged
+186
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymarczy
commented
Feb 4, 2025
Comment on lines
+25
to
+34
| pass | ||
| # Delete status files for all tables loaded since the NOT NULL Primary Key requirement was dropped. | ||
| # This will force a reset/re-load for these tables in dmap-import DB | ||
| s3_delete_object(os.path.join(ODS_STATUS, "EDW.PAYMENT_SUMMARY.json")) | ||
| s3_delete_object(os.path.join(ODS_STATUS, "EDW.MEMBER_DIMENSION.json")) | ||
| op.drop_table("edw_payment_summary", schema="ods") | ||
| op.drop_table("edw_payment_summary_history", schema="ods") | ||
| op.drop_table("edw_member_dimension", schema="ods") | ||
| op.drop_table("edw_member_dimension_history", schema="ods") | ||
| # This was one-time migration, does not need to remain active | ||
| # s3_delete_object(os.path.join(ODS_STATUS, "EDW.PAYMENT_SUMMARY.json")) | ||
| # s3_delete_object(os.path.join(ODS_STATUS, "EDW.MEMBER_DIMENSION.json")) | ||
| # op.drop_table("edw_payment_summary", schema="ods") | ||
| # op.drop_table("edw_payment_summary_history", schema="ods") | ||
| # op.drop_table("edw_member_dimension", schema="ods") | ||
| # op.drop_table("edw_member_dimension_history", schema="ods") |
There was a problem hiding this comment.
This was causing issues during local testing, should never need to be run again.
rymarczy
commented
Feb 4, 2025
| @@ -445,7 +445,7 @@ def snapshot_reset(self) -> None: | |||
| self.etl_status = self.load_etl_status() | |||
|
|
|||
| self.db.execute(drop_table(self.db_history_table)) | |||
| self.db.execute(drop_table(self.db_fact_table)) | |||
| self.db.truncate_table(self.db_fact_table, restart_identity=True, cascade=True) | |||
There was a problem hiding this comment.
Drop command was causing VIEWS to get dropped...
rymarczy
commented
Feb 4, 2025
| @@ -0,0 +1,134 @@ | |||
| AD_HOC_VIEW = """ | |||
There was a problem hiding this comment.
Keep these VIEW statements in central location.
grejdi-mbta
reviewed
Feb 4, 2025
| op.drop_table("edw_member_dimension", schema="ods") | ||
| op.drop_table("edw_member_dimension_history", schema="ods") | ||
| # This was one-time migration, does not need to remain active | ||
| # s3_delete_object(os.path.join(ODS_STATUS, "EDW.PAYMENT_SUMMARY.json")) |
There was a problem hiding this comment.
I gotta tell you. This concept of using migrations to do other migration-related things blew my mind. 😂
grejdi-mbta
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes the following: