Disable RTL support #725
Merged
Disable RTL support #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, the app doesn't support any languages that are written from right to left, such as Hebrew or Arabic. However, AndroidManifest.xml says android:supportsRtl="true", which is the default value. This causes the app to display incorrectly in English on phones that are set to work in a right to left language. This patch sets rtlandroid:supportsRtl="false", so that the app won't try to flip itself for right to left languages unnecessarily. If full support for such languages is ever added, set it back to "true".
KaylaBrady
approved these changes
Feb 10, 2025
Thanks for approving! Is there anything I can do to fix the CI failure? |
|
@amire80 I am working on a fix for the CI issue, sorry for the delay! |
|
Thanks again @amire80! |
|
Thank you for the quick review and the CI fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the app doesn't support any languages that are written from right to left, such as Hebrew or Arabic.
However, AndroidManifest.xml says android:supportsRtl="true", which is the default value. This causes the app to display incorrectly in English on phones that are set to work in a right to left language.
This patch sets rtlandroid:supportsRtl="false",
so that the app won't try to flip itself for
right to left languages unnecessarily.
If full support for such languages is ever added,
set it back to "true".