Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable crowding audio at Back Bay platform for 12-11 demo #726

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Enable crowding audio at Back Bay platform for 12-11 demo #726

merged 2 commits into from
Dec 14, 2023

Conversation

PaulJKim
Copy link
Collaborator

@PaulJKim PaulJKim commented Dec 8, 2023

Ad-Hoc

To be deployed around 8am on Monday morning (12/11/23) for an in-station demo

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Coverage of commit 00d272a

Summary coverage rate:
  lines......: 76.5% (1945 of 2543 lines)
  functions..: 78.5% (528 of 673 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/signs/utilities/audio.ex                               |86.4%    118| 100%    15|    -      0

Download coverage report

@PaulJKim PaulJKim requested a review from panentheos December 8, 2023 19:02
panentheos
panentheos approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@panentheos panentheos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, then looks good.

lib/signs/utilities/audio.ex Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Coverage of commit fb3c56f

Summary coverage rate:
  lines......: 76.5% (1945 of 2543 lines)
  functions..: 78.5% (528 of 673 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/signs/utilities/audio.ex                               |86.4%    118| 100%    15|    -      0

Download coverage report

@PaulJKim PaulJKim merged commit cf8553a into main Dec 14, 2023
1 check passed
@PaulJKim PaulJKim deleted the pk/ol-crowding-demo-12-11 branch December 14, 2023 12:27
PaulJKim added a commit that referenced this pull request Dec 14, 2023
@PaulJKim
Revert "Enable crowding audio at Back Bay platform for 12-11 demo (#726…
5e71c2d 
…)"

This reverts commit cf8553a.
@PaulJKim PaulJKim mentioned this pull request Dec 14, 2023
Merged
PaulJKim added a commit that referenced this pull request Dec 14, 2023
@PaulJKim
Revert "Enable crowding audio at Back Bay platform for 12-11 demo (#726…
1638507 
…)" (#728)

This reverts commit cf8553a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panentheos panentheos panentheos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulJKim @panentheos