formalize logging of sign content and generate tags #817
Conversation
| @@ -23,20 +23,26 @@ defmodule PaEss.Updater do | |||
| _ -> nil | |||
| end | |||
|
|
|||
| log_meta = [sign_id: id, current_config: log_config] | |||
| visual = zip_pages(top, bottom) |> format_pages() | |||
| tag = create_tag() | |||
There was a problem hiding this comment.
Actually, a question came to mind while working on the dashboard. Is it possible to default tag to nil for legacy? It would make it easier to tell legacy and migrated messages apart and would allow me to display N/A in the playback column.
There was a problem hiding this comment.
Instead of that, how about another explicit field that specifies whether it's legacy? Part of the goal here is to start unifying the shape of the logs as much as possible, so I wanted to start exposing this data so we can build dashboards to that spec (but yeah, we still need a way to differentiate legacy messages)
There was a problem hiding this comment.
Yea I like that better. Much less likely to cause confusion way down the line.
Summary of changes
Asana Ticket: Improve RTS and SCU message logging
This adds
audio,visual, andtagfields to RTS message logs, with JSON-parseable visual data.tagis not helpful for legacy stations, but after migration, SCUs will log this tag in their own output, allowing us to trace message playback.